[tex-live] Patch to make gui installer usable from keyboard

Norbert Preining preining at logic.at
Sun Oct 11 07:06:44 CEST 2009

Hi Alex,

Thanks a lot, nice patch. I have committed it with one small fix.

On So, 11 Okt 2009, Alexander Cherepanov wrote:
> --- installer.orig/install-menu-perltk.pl	2009-10-10 15:55:28.750000000 +0400
> +++ installer/install-menu-perltk.pl	2009-10-10 22:11:37.531250000 +0400
> @@ -367,7 +367,7 @@
>    my $b = $f->Button(-text => __("Cancel"),
>                       -command => sub { $::sww->destroy; $mainwindow->destroy;
>                                         do_cleanup(); exit(1); }
> -                    )->pack(-pady => "2m");
> +                    )->pack(-pady => "2m")->focus();

That was not a good idea, since at the end we call
to change the text to "Finished", and with that $b is undefined (the return
value of focus()!)

> Tested on Windows only.

Did the final button *actually* change from "Cancel" to "Finish" and there
has not been any warning on the cmd line with the perltk installer? I would
be surprised.

Anyway, with my fix (adding above a $b->focus(); instaead of attaching the
->focus()) it works now.

Thanks a lot!!!

Best wishes


Dr. Norbert Preining                                        Associate Professor
JAIST Japan Advanced Institute of Science and Technology   preining at jaist.ac.jp
Vienna University of Technology                               preining at logic.at
Debian Developer (Debian TeX Task Force)                    preining at debian.org
gpg DSA: 0x09C5B094      fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
(aikamuotojen käyttö aikamatkustuksessa)
You can arrive (mayan arivan on-when) for any sitting you
like without prior (late fore-when) reservation because you
can book retrospectively, as it were when you return to
your own time. (you can have on-book haventa forewhen
presooning returningwenta retrohome.)
                 --- Douglas Adams, The Hitchhikers Guide to the Galaxy

More information about the tex-live mailing list