[tex-live] Patch to updmap.pl

Zdenek Wagner zdenek.wagner at gmail.com
Tue Sep 4 01:30:35 CEST 2007


2007/9/4, Karl Berry <karl at freefriends.org>:
>     -      if ($value =~ m/^(true|yes|t|y|1)$/) {
>     -       $value = 1;
>     +      if ($variable eq "LW35") {
>     +        print "$variable => $value\n";
>            }
>            else {
>     -       $value = 0;
>     +        if ($value =~ m/^(true|yes|t|y|1)$/) {
>     +         $value = 1;
>     +        }
>     +        else {
>     +         $value = 0;
>     +        }
>
> I don't understand this change.  What problem is being fixed?
>
>     -  $mode = "URWkb" if ($mode = undef);
>     +  $mode = "URWkb" if ($mode eq undef);
>
> The original is certainly wrong, but the replacement looks strange too,
> as Joachim said.  Glancing at the code, I surmise we do want to check
> against the empty string, so I changed things accordingly.
>
If we do want to check against either an empty string or undefined,
it's even simpler to write

$mode = "URWkb" unless $mode;

Notice that parenthese are not necessary.

> I have no way to test it.  If anyone using Windows can do so, that would
> be nice.  (Of course it would be nice to unify Windows and Unix, as we
> all know very well, but that's not going to happen today.)
>
> Best,
> k
>
>


-- 
Zdeněk Wagner
http://hroch486.icpf.cas.cz/wagner/
http://icebearsoft.euweb.cz


More information about the tex-live mailing list